SF-3875 Improve note sync performance - #4003

@Nateowami Has this bug been reported to the Paratext team? I can't actually think of a way of fixing the bug within Comment.CompareTo(), as it seems a grouping (which your code does) is needed to fix the sorting.

@pmachapman reviewed 4 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Nateowami).

src/SIL.XForge.Scripture/Services/CommentManagerExtensions.cs line 41 at r1 (raw file):

                threads.Add(thread);
            }
        }

We could speed this up by iterating over manager.AllComments, then building the CommentThreads from there. In particular, we would group then sort the comments correctly via our own version of the logic in CommentManager.SortAndGroupThreads.

I'm not making this blocking, as I am interested in your thoughts, although perhaps I lean towards us implementing our own iterator as the PT CommentManager.FindThreads() code has not changed in years?

Code quote:

        foreach (CommentThread thread in manager.FindThreads())
        {
            if (threadIndexById.TryGetValue(thread.Id, out int index))
                threads[index] = manager.FindThread(thread.Id);
            else
            {
                threadIndexById[thread.Id] = threads.Count;
                threads.Add(thread);
            }
        }

@Nateowami made 1 comment and resolved 1 discussion.
Reviewable status: 2 of 4 files reviewed, all discussions resolved (waiting on pmachapman).

src/SIL.XForge.Scripture/Services/CommentManagerExtensions.cs line 41 at r1 (raw file):

Done.

@pmachapman reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on Nateowami).